pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42211?usp=email )
Change subject: tcap: Lower log level failing to parse msg ......................................................................
tcap: Lower log level failing to parse msg
invalid rx packets should be logged as NOTICED, not as ERROR.
Change-Id: Idef5736ee2481260f958eece2f5a3bfc009b3d69 --- M src/tcap_as_loadshare.c 1 file changed, 9 insertions(+), 9 deletions(-)
Approvals: osmith: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified
diff --git a/src/tcap_as_loadshare.c b/src/tcap_as_loadshare.c index 336692d..803dcd8 100644 --- a/src/tcap_as_loadshare.c +++ b/src/tcap_as_loadshare.c @@ -78,7 +78,7 @@
rc = osmo_asn1_tcap_decode(tcapmsg, data, len); if (rc < 0) { - LOGPAS(as, DLTCAP, LOGL_DEBUG, "Error decoding TCAP message rc: %d, message: %s\n", + LOGPAS(as, DLTCAP, LOGL_NOTICE, "Error decoding TCAP message rc: %d, message: %s\n", rc, osmo_hexdump(data, len)); goto free_asn; } @@ -280,7 +280,7 @@ int rc; struct xua_msg *sua = osmo_sccp_to_xua(sccp_msg); if (!sua) { - LOGPAS(as, DLTCAP, LOGL_ERROR, "Unable to parse SCCP message\n"); + LOGPAS(as, DLTCAP, LOGL_NOTICE, "Unable to parse SCCP message\n"); return -1; }
@@ -290,14 +290,14 @@
rc = sua_addr_parse(&calling_addr, sua, SUA_IEI_SRC_ADDR); if (rc < 0) { - LOGPAS(as, DLTCAP, LOGL_ERROR, "Unable to parse SCCP Destination Address\n"); + LOGPAS(as, DLTCAP, LOGL_NOTICE, "Unable to parse SCCP Destination Address\n"); return -3; }
/* retrieve + decode destination address */ rc = sua_addr_parse(&called_addr, sua, SUA_IEI_DEST_ADDR); if (rc < 0) { - LOGPAS(as, DLTCAP, LOGL_ERROR, "Unable to parse SCCP Destination Address\n"); + LOGPAS(as, DLTCAP, LOGL_NOTICE, "Unable to parse SCCP Destination Address\n"); return -4; }
@@ -325,7 +325,7 @@
rc = parse_tcap(as, ie_data->dat, ie_data->len, &parsed); if (rc <= 0) { - LOGPAS(as, DLTCAP, LOGL_ERROR, "Failed get TCAP otid/dtid.\n"); + LOGPAS(as, DLTCAP, LOGL_NOTICE, "Failed get TCAP otid/dtid.\n"); return -7; }
@@ -451,7 +451,7 @@ /* decode SCCP and convert to a SUA/xUA representation */ sua = osmo_sccp_to_xua(sccp_msg); if (!sua) { - LOGPAS(as, DLTCAP, LOGL_ERROR, "Unable to parse SCCP message\n"); + LOGPAS(as, DLTCAP, LOGL_NOTICE, "Unable to parse SCCP message\n"); rc = -EPROTONOSUPPORT; goto out_free_msgb; } @@ -465,13 +465,13 @@
rc = sua_addr_parse(&calling_addr, sua, SUA_IEI_SRC_ADDR); if (rc < 0) { - LOGPAS(as, DLTCAP, LOGL_ERROR, "Unable to parse SCCP Source Address\n"); + LOGPAS(as, DLTCAP, LOGL_NOTICE, "Unable to parse SCCP Source Address\n"); goto out_free_sua; }
rc = sua_addr_parse(&called_addr, sua, SUA_IEI_DEST_ADDR); if (rc < 0) { - LOGPAS(as, DLTCAP, LOGL_ERROR, "Unable to parse SCCP Destination Address\n"); + LOGPAS(as, DLTCAP, LOGL_NOTICE, "Unable to parse SCCP Destination Address\n"); goto out_free_sua; }
@@ -505,7 +505,7 @@
if (rc <= 0) { rate_ctr_inc2(as->ctrg, SS7_AS_CTR_RX_TCAP_FAILED); - LOGPAS(as, DLTCAP, LOGL_ERROR, "Failed get TCAP otid/dtid.\n"); + LOGPAS(as, DLTCAP, LOGL_NOTICE, "Failed get TCAP otid/dtid.\n"); rc = -EINVAL; goto out_free_sua; }
-
pespin