Attention is currently required from: laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30048 ) Change subject: vty/logging.h: Avoid -Werror=pragmas error in C++ code ...................................................................... Patch Set 1: Verified+1 Code-Review+2 (2 comments) Patchset: PS1: Patch looks good. Also I've reproduced the error locally and verified that this fixes it with osmo-pcu. File include/osmocom/vty/logging.h: https://gerrit.osmocom.org/c/libosmocore/+/30048/comment/eb42158c_6a337eb4 PS1, Line 15: #pragma GCC diagnostic pop oh right, nvm -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30048 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I85596cf4538d7a8c522f4bce1620a2d19e2a910e Gerrit-Change-Number: 30048 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 07 Nov 2022 09:23:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment