Change in libosmo-gprs[master]: rlcmac: rename s/IA_EGPRS_00_t/IA_EGPRS_PktUlAss_t/ - gerrit-log

2 Jan 2023

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/30799 )
Change subject: rlcmac: rename s/IA_EGPRS_00_t/IA_EGPRS_PktUlAss_t/
......................................................................
rlcmac: rename s/IA_EGPRS_00_t/IA_EGPRS_PktUlAss_t/
Use a self-explanatory name instead of the one with magic numbers.
It's safe to rename it because this API is not used anywhere yet.
Change-Id: I884cba359bfda21cf45fa846e5b7ff20d129bdf7
Related: OS#5500
---
M include/osmocom/gprs/rlcmac/gprs_rlcmac.h
M src/rlcmac/ts_44_018.c
M tests/rlcmac/ts_44_018_test.err
3 files changed, 12 insertions(+), 12 deletions(-)
Approvals:
  laforge: Looks good to me, but someone else must approve
  fixeria: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

diff --git a/include/osmocom/gprs/rlcmac/gprs_rlcmac.h b/include/osmocom/gprs/rlcmac/gprs_rlcmac.h
index d5912c9..f322455 100644
--- a/include/osmocom/gprs/rlcmac/gprs_rlcmac.h
+++ b/include/osmocom/gprs/rlcmac/gprs_rlcmac.h
@@ -673,7 +673,7 @@
     EGPRS_TwoPhaseAccess_t TwoPhaseAccess; /* 04.18/10.5.2.16 Multiblock allocation */
     EGPRS_OnePhaseAccess_t OnePhaseAccess; /* 04.60/10.5.2.16 TFI using Dynamic or Fixed Allocation */
   } Access;
-} IA_EGPRS_00_t;
+} IA_EGPRS_PktUlAss_t;
typedef struct
 {
@@ -816,7 +816,7 @@
 {
   guint8 UnionType;
   union {
-    IA_EGPRS_00_t IA_EGPRS_PUA;
+    IA_EGPRS_PktUlAss_t EGPRS_PktUlAss;
     /* TODO: <Multiple Blocks Packet Downlink Assignment> */
   } u;
 } IA_RestOctetsLH0x_t;
diff --git a/src/rlcmac/ts_44_018.c b/src/rlcmac/ts_44_018.c
index 5481166..fd30416 100644
--- a/src/rlcmac/ts_44_018.c
+++ b/src/rlcmac/ts_44_018.c
@@ -217,15 +217,15 @@
/* < EGPRS Packet Uplink Assignment > */
 static const
-CSN_DESCR_BEGIN(IA_EGPRS_00_t)
-  M_UINT       (IA_EGPRS_00_t,  ExtendedRA,  5),
+CSN_DESCR_BEGIN(IA_EGPRS_PktUlAss_t)
+  M_UINT       (IA_EGPRS_PktUlAss_t,  ExtendedRA,  5),
-  M_REC_ARRAY  (IA_EGPRS_00_t, AccessTechnologyType, NrOfAccessTechnologies, 4),
+  M_REC_ARRAY  (IA_EGPRS_PktUlAss_t, AccessTechnologyType, NrOfAccessTechnologies, 4),
-  M_UNION      (IA_EGPRS_00_t, 2),
-  M_TYPE       (IA_EGPRS_00_t, Access.TwoPhaseAccess, EGPRS_TwoPhaseAccess_t),
-  M_TYPE       (IA_EGPRS_00_t, Access.OnePhaseAccess, EGPRS_OnePhaseAccess_t),
-CSN_DESCR_END  (IA_EGPRS_00_t)
+  M_UNION      (IA_EGPRS_PktUlAss_t, 2),
+  M_TYPE       (IA_EGPRS_PktUlAss_t, Access.TwoPhaseAccess, EGPRS_TwoPhaseAccess_t),
+  M_TYPE       (IA_EGPRS_PktUlAss_t, Access.OnePhaseAccess, EGPRS_OnePhaseAccess_t),
+CSN_DESCR_END  (IA_EGPRS_PktUlAss_t)
static const
 CSN_DESCR_BEGIN(IA_FreqParamsBeforeTime_t)
@@ -357,7 +357,7 @@
 static const
 CSN_DESCR_BEGIN    (IA_RestOctetsLH0x_t)
   M_UNION          (IA_RestOctetsLH0x_t, 2),
-  M_TYPE           (IA_RestOctetsLH0x_t, u.IA_EGPRS_PUA, IA_EGPRS_00_t),
+  M_TYPE           (IA_RestOctetsLH0x_t, u.EGPRS_PktUlAss, IA_EGPRS_PktUlAss_t),
   CSN_ERROR        (IA_RestOctetsLH0x_t, "01 <Multiple Blocks Packet Downlink Assignment>", CSN_ERROR_STREAM_NOT_SUPPORTED),
 CSN_DESCR_END      (IA_RestOctetsLH0x_t)
diff --git a/tests/rlcmac/ts_44_018_test.err b/tests/rlcmac/ts_44_018_test.err
index 8b804a5..61d77c8 100644
--- a/tests/rlcmac/ts_44_018_test.err
+++ b/tests/rlcmac/ts_44_018_test.err
@@ -6,5 +6,5 @@
 DLCSN1 INFO osmo_csn1_stream_decode (IA Rest Octets): u.hh = 3 |  : u.hh | u.UplinkDownlinkAssignment = 0 |  : u.UplinkDownlinkAssignment | ul_dl.Packet_Uplink_ImmAssignment = 0 |  : ul_dl.Packet_Uplink_ImmAssignment | Access.DynamicOrFixedAllocation = 1 |  : Access.DynamicOrFixedAllocation | TFI_ASSIGNMENT = 3 | POLLING = 0 | Allocation.DynamicAllocation = 0 |  : Allocation.DynamicAllocation | USF = 1 | USF_GRANULARITY = 0 | Exist_P0_PR_MODE = 1 | P0 = 0 | PR_MODE = 1 |  : End Allocation.DynamicAllocation | CHANNEL_CODING_COMMAND = 1 | TLLI_BLOCK_CHANNEL_CODING = 1 | Exist_ALPHA = 0 | GAMMA = 15 | Exist_TIMING_ADVANCE_INDEX = 1 | TIMING_ADVANCE_INDEX = 0 | Exist_TBF_STARTING_TIME = 0 |  : End Access.DynamicOrFixedAllocation | Exist_AdditionsR99 = 0 |  : End ul_dl.Packet_Uplink_ImmAssignment |  : End u.UplinkDownlinkAssignment | Exist_AdditionsR10 = 0 | Exist_AdditionsR13 = 0 |  : End u.hh | Padding = 43|43|43|43|43|0|
 DLCSN1 INFO osmo_csn1_stream_decode (IA Rest Octets): u.hh = 3 |  : u.hh | u.UplinkDownlinkAssignment = 0 |  : u.UplinkDownlinkAssignment | ul_dl.Packet_Uplink_ImmAssignment = 0 |  : ul_dl.Packet_Uplink_ImmAssignment | Access.SingleBlockAllocation = 0 |  : Access.SingleBlockAllocation | Exist_ALPHA = 0 | GAMMA = 15 | 0x01 = 1 |  : TBF_STARTING_TIME | N32 = 14 | N51 = 50 | N26 = 13 | : End TBF_STARTING_TIME | Exist_P0_BTS_PWR_CTRL_PR_MODE = 0 |  : End Access.SingleBlockAllocation | Exist_AdditionsR99 = 0 |  : End ul_dl.Packet_Uplink_ImmAssignment |  : End u.UplinkDownlinkAssignment | Exist_AdditionsR10 = 0 | Exist_AdditionsR13 = 0 |  : End u.hh | Padding = 21|149|149|149|149|128|-22|
 DLCSN1 INFO osmo_csn1_stream_decode (IA Rest Octets): u.hh = 3 |  : u.hh | u.UplinkDownlinkAssignment = 0 |  : u.UplinkDownlinkAssignment | ul_dl.Packet_Downlink_ImmAssignment = 1 |  : ul_dl.Packet_Downlink_ImmAssignment | TLLI = 0xd6e1ae5a | Exist_TFI_to_TA_VALID = 1 | TFI_ASSIGNMENT = 3 | RLC_MODE = 0 | Exist_ALPHA = 0 | GAMMA = 15 | POLLING = 0 | TA_VALID = 0 | Exist_TIMING_ADVANCE_INDEX = 0 | Exist_TBF_STARTING_TIME = 0 | Exist_P0_PR_MODE = 1 | P0 = 0 | BTS_PWR_CTRL_MODE = 0 | PR_MODE = 1 | Exist_AdditionsR99 = 0 |  : End ul_dl.Packet_Downlink_ImmAssignment |  : End u.UplinkDownlinkAssignment | Exist_AdditionsR10 = 0 | Exist_AdditionsR13 = 0 |  : End u.hh | Padding = 0|86|86|-22|
-DLCSN1 INFO osmo_csn1_stream_decode (IA Rest Octets): u.lh = 1 |  : u.lh | lh0x = 0 |  : lh0x | u.IA_EGPRS_PUA = 0 |  : u.IA_EGPRS_PUA | ExtendedRA = 12 | AccessTechnologyType = Exist | AccessTechnologyType = 0 | AccessTechnologyType = Exist | AccessTechnologyType = 3 | AccessTechnologyType = 0 | Access.OnePhaseAccess = 1 |  : Access.OnePhaseAccess | TFI_ASSIGNMENT = 7 | POLLING = 0 | Allocation.DynamicAllocation = 0 |  : Allocation.DynamicAllocation | USF = 3 | USF_GRANULARITY = 0 | Exist_P0_PR_MODE = 0 |  : End Allocation.DynamicAllocation | EGPRS_CHANNEL_CODING_COMMAND = 2 | TLLI_BLOCK_CHANNEL_CODING = 1 | Exist_BEP_PERIOD2 = 1 | BEP_PERIOD2 = 5 | RESEGMENT = 1 | EGPRS_WindowSize = 4 | Exist_ALPHA = 0 | GAMMA = 13 | Exist_TIMING_ADVANCE_INDEX = 1 | TIMING_ADVANCE_INDEX = 0 | Exist_TBF_STARTING_TIME = 0 |  : End Access.OnePhaseAccess |  : End u.IA_EGPRS_PUA |  : End lh0x |  : AdditionsR13 | Exist_AdditionsR13 = 0 | : End AdditionsR13 |  : End u.lh | Padding = 0|172|172|-22|
-DLCSN1 INFO osmo_csn1_stream_decode (IA Rest Octets): u.lh = 1 |  : u.lh | lh0x = 0 |  : lh0x | u.IA_EGPRS_PUA = 0 |  : u.IA_EGPRS_PUA | ExtendedRA = 8 | AccessTechnologyType = Exist | AccessTechnologyType = 0 | AccessTechnologyType = Exist | AccessTechnologyType = 3 | AccessTechnologyType = 0 | Access.TwoPhaseAccess = 0 |  : Access.TwoPhaseAccess | Exist_ALPHA = 0 | GAMMA = 13 |  : TBF_STARTING_TIME | N32 = 20 | N51 = 45 | N26 = 0 | : End TBF_STARTING_TIME | NR_OF_RADIO_BLOCKS_ALLOCATED = 1 | Exist_P0_BTS_PWR_CTRL_PR_MODE = 0 |  : End Access.TwoPhaseAccess |  : End u.IA_EGPRS_PUA |  : End lh0x |  : AdditionsR13 | Exist_AdditionsR13 = 0 | : End AdditionsR13 |  : End u.lh | Padding = 0|86|86|86|86|-22|
+DLCSN1 INFO osmo_csn1_stream_decode (IA Rest Octets): u.lh = 1 |  : u.lh | lh0x = 0 |  : lh0x | u.EGPRS_PktUlAss = 0 |  : u.EGPRS_PktUlAss | ExtendedRA = 12 | AccessTechnologyType = Exist | AccessTechnologyType = 0 | AccessTechnologyType = Exist | AccessTechnologyType = 3 | AccessTechnologyType = 0 | Access.OnePhaseAccess = 1 |  : Access.OnePhaseAccess | TFI_ASSIGNMENT = 7 | POLLING = 0 | Allocation.DynamicAllocation = 0 |  : Allocation.DynamicAllocation | USF = 3 | USF_GRANULARITY = 0 | Exist_P0_PR_MODE = 0 |  : End Allocation.DynamicAllocation | EGPRS_CHANNEL_CODING_COMMAND = 2 | TLLI_BLOCK_CHANNEL_CODING = 1 | Exist_BEP_PERIOD2 = 1 | BEP_PERIOD2 = 5 | RESEGMENT = 1 | EGPRS_WindowSize = 4 | Exist_ALPHA = 0 | GAMMA = 13 | Exist_TIMING_ADVANCE_INDEX = 1 | TIMING_ADVANCE_INDEX = 0 | Exist_TBF_STARTING_TIME = 0 |  : End Access.OnePhaseAccess |  : End u.EGPRS_PktUlAss |  : End lh0x |  : AdditionsR13 | Exist_AdditionsR13 = 0 | : End AdditionsR13 |  : End u.lh | Padding = 0|172|172|-22|
+DLCSN1 INFO osmo_csn1_stream_decode (IA Rest Octets): u.lh = 1 |  : u.lh | lh0x = 0 |  : lh0x | u.EGPRS_PktUlAss = 0 |  : u.EGPRS_PktUlAss | ExtendedRA = 8 | AccessTechnologyType = Exist | AccessTechnologyType = 0 | AccessTechnologyType = Exist | AccessTechnologyType = 3 | AccessTechnologyType = 0 | Access.TwoPhaseAccess = 0 |  : Access.TwoPhaseAccess | Exist_ALPHA = 0 | GAMMA = 13 |  : TBF_STARTING_TIME | N32 = 20 | N51 = 45 | N26 = 0 | : End TBF_STARTING_TIME | NR_OF_RADIO_BLOCKS_ALLOCATED = 1 | Exist_P0_BTS_PWR_CTRL_PR_MODE = 0 |  : End Access.TwoPhaseAccess |  : End u.EGPRS_PktUlAss |  : End lh0x |  : AdditionsR13 | Exist_AdditionsR13 = 0 | : End AdditionsR13 |  : End u.lh | Padding = 0|86|86|86|86|-22|
-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/30799
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I884cba359bfda21cf45fa846e5b7ff20d129bdf7
Gerrit-Change-Number: 30799
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-MessageType: merged



    