Attention is currently required from: falconia, neels, nt2mku.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36784?usp=email )
Change subject: gsm48_encode_bearer_cap(): omit octet 3a if only GSM-FR/GSM-HR v1 is supported
......................................................................
Patch Set 10:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/libosmocore/+/36784/comment/4bfb2975_865e03ff
PS2, Line 9: Some early GSM phones (like the Siemens P1 Porty) do not accept a mobile-terminating call setup if octet 3a is present. If speech version is GSM-FR (v1, 0x00) only, omit octet 3a.
Not addressed.
Done
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/36784?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia09abb32a8458384151a6ae28744835ea440fc5b
Gerrit-Change-Number: 36784
Gerrit-PatchSet: 10
Gerrit-Owner: nt2mku
degrunert.web@googlemail.com
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: neels
nhofmeyr@sysmocom.de
Gerrit-CC: falconia
falcon@freecalypso.org
Gerrit-CC: pespin
pespin@sysmocom.de
Gerrit-Attention: falconia
falcon@freecalypso.org
Gerrit-Attention: neels
nhofmeyr@sysmocom.de
Gerrit-Attention: nt2mku
degrunert.web@googlemail.com
Gerrit-Comment-Date: Wed, 29 May 2024 07:39:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels
nhofmeyr@sysmocom.de
Comment-In-Reply-To: fixeria
vyanitskiy@sysmocom.de
Gerrit-MessageType: comment