Attention is currently required from: pespin.
Hoernchen has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-trx/+/30486 )
Change subject: clean up mutex, scopedlock, and signal classes
......................................................................
Patch Set 2:
(2 comments)
File Transceiver52M/Transceiver.cpp:
https://gerrit.osmocom.org/c/osmo-trx/+/30486/comment/521f3567_29be7fd8
PS1, Line 212:
> trailing whitespace […]
Done
File Transceiver52M/radioInterface.cpp:
https://gerrit.osmocom.org/c/osmo-trx/+/30486/comment/c9d1485e_9cd9ac16
PS1, Line 61: close();
why is this close() removed?
it was previously
used to reset/initialize the buffers... not necessary with proper initialization.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-trx/+/30486
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Idc9e3b1144c5b93f5dad2f8e0e30f1058477aa52
Gerrit-Change-Number: 30486
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 06 Dec 2022 10:16:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment