Attention is currently required from: fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/29384 ) Change subject: vty doc: indicate default nft table name ...................................................................... Patch Set 2: (1 comment) File src/osmo-upf/upf_vty.c: https://gerrit.osmocom.org/c/osmo-upf/+/29384/comment/669f951d_af3c6f42 PS2, Line 239: "Set the nft inet table name to create and place GTP tunnel forwarding chains in" The VTY actually is a *good* place for verbose explanation: The explanations written here are placed in the vty-reference PDF, where there is unlimited space; the more concise information written in the VTY reference document, the better. On the live telnet vty prompt, long explanations are nicely structured with line breaks; The doc is only shown on explicit user request. No reason to be brief. So here, also, complete explanations are a good thing. My general opinion is that there should be a lot more verbose explanations in the vty doc. -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/29384 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I79b4d287cae47c37b45a35904f298e57120a65f0 Gerrit-Change-Number: 29384 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 19 Sep 2022 10:10:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment