Attention is currently required from: neels.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/36452?usp=email )

Change subject: fix VLR evil twin on LU with unknown TMSI ......................................................................

Patch Set 1:

(3 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmo-msc/+/36452/comment/344f85e7_d4a0d87a PS1, Line 15: be discarded, for the benefit of the new one. we do the same in osmo-pcu with tbfs btw (ms_merge_and_clear_ms()).

File src/libmsc/paging.c:

https://gerrit.osmocom.org/c/osmo-msc/+/36452/comment/16cfd6af_fe5db9e1 PS1, Line 147: vlr_subscr_put(discarding_vsub, VSUB_USE_PAGING); Shouldn't this happen only "if discarding_vsub->cs.is_paging"?

File src/libvlr/vlr.c:

https://gerrit.osmocom.org/c/osmo-msc/+/36452/comment/ca39f788_f7e3f283 PS1, Line 597: struct vlr_instance *vlr = exists->vlr; I'd rpobably move all this code to its own function "vsub_join()" or alike.