[M] Change in osmocom-bb[master]: trx_toolkit/*: Try to avoid copying burst data where possible - gerrit-log

12 Feb 2025


      Attention is currently required from: kirr.
pespin has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/39537?usp=email )
Change subject: trx_toolkit/*: Try to avoid copying burst data where possible
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/target/trx_toolkit/data_msg.py:
https://gerrit.osmocom.org/c/osmocom-bb/+/39537/comment/d6a148e9_5a0946f7?us... :
PS2, Line 336: 				burst = memoryview(burst)[:EDGE_BURST_LEN]
Just speculating here, but with the new version you posted you are still potentially creating a copy of the slice and assigning it var burst.
-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/39537?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I147da2f110dedc863361059c931f609c28a69e9c
Gerrit-Change-Number: 39537
Gerrit-PatchSet: 2
Gerrit-Owner: kirr kirr@nexedi.com
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-CC: fixeria vyanitskiy@sysmocom.de
Gerrit-CC: osmith osmith@sysmocom.de
Gerrit-Attention: kirr kirr@nexedi.com
Gerrit-Comment-Date: Wed, 12 Feb 2025 22:49:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes