Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/28725 )

Change subject: Introduce APDU/TPDU trace decoder ......................................................................

Patch Set 1:

(2 comments)

File pySim/gsmtap.py:

https://gerrit.osmocom.org/c/pysim/+/28725/comment/a23abdea_c457679f PS1, Line 153: Int8ub

I would use Const(b'\x02') to enforce GSMTAPv2 (GSMTAP_VERSION).

Well, the check in the code allows us to be more flexible, I think it's one of those situation where I can't say one is clearly better than the other.

File pySim/ts_31_102.py:

https://gerrit.osmocom.org/c/pysim/+/28725/comment/747256b9_e697db5a PS1, Line 303: # 3gPP TS 31.102 Section 7.5.2.1

unrelated?

why is it unrelated? That DataObject is referenced in the tracer:

pySim/apdu/ts_31_102.py:from pySim.ts_31_102 import SUCI_TlvDataObject