Change in libosmocore[master]: coding: fix decoding of AHS_SID_UPDATE frames (BER ~50%) - gerrit-log

19 May 2022


      Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28166 )
Change subject: coding: fix decoding of AHS_SID_UPDATE frames (BER ~50%)
......................................................................
Patch Set 1:
(2 comments)
File src/coding/gsm0503_coding.c:
https://gerrit.osmocom.org/c/libosmocore/+/28166/comment/f8e7ccd2_1006b8c8 
PS1, Line 2685: 		case AMR_OTHER:
so no more "AMR_OTHER" case now? It goes into default?
File tests/dtx/dtx_gsm0503_test.ok:
https://gerrit.osmocom.org/c/libosmocore/+/28166/comment/72052ae6_4d50ad26 
PS1, Line 23:  ==> gsm0503_tch_ahs_decode_dtx() yields 'AMR_OTHER (audio)' (rc=-1, BER 111/212)
Shouldn't this be BER 212/212?
-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28166
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I8686d895e96fa0e606c1898b6574cc80a8f46983
Gerrit-Change-Number: 28166
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Thu, 19 May 2022 19:41:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment