fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28810 )
Change subject: trxcon: assert *ts is not NULL in l1sched_set_lchans ......................................................................
trxcon: assert *ts is not NULL in l1sched_set_lchans
We cannot use ts->sched as logging context because ts is NULL.
Change-Id: I53b40b31f20fc9aefdfcac1406c465d226e5fde0 Related: CID#275337 --- M src/host/trxcon/src/sched_trx.c 1 file changed, 1 insertion(+), 4 deletions(-)
Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved
diff --git a/src/host/trxcon/src/sched_trx.c b/src/host/trxcon/src/sched_trx.c index 10a4c5f..af2d9b3 100644 --- a/src/host/trxcon/src/sched_trx.c +++ b/src/host/trxcon/src/sched_trx.c @@ -418,10 +418,7 @@ int rc = 0;
/* Prevent NULL-pointer deference */ - if (ts == NULL) { - LOGP_SCHEDC(ts->sched, LOGL_ERROR, "Timeslot isn't configured\n"); - return -EINVAL; - } + OSMO_ASSERT(ts != NULL);
/* Iterate over all allocated lchans */ llist_for_each_entry(lchan, &ts->lchans, list) {
-
fixeria