Attention is currently required from: osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/29279 )

Change subject: llc: gprs_llc_hdr_parse(): make the input data pointer const ......................................................................

Patch Set 1:

(1 comment)

File src/gprs/gprs_llc_parse.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/29279/comment/cf293d55_660c0822 PS1, Line 138: ghp->data = (uint8_t *)&ctrl[3];

The compiler may make optimizations based on what passed to the function. […]

The main point of using const is *not* to assist the compiler in optimizations but to protect yourself from mistakes... I am telling the API user that gprs_llc_hdr_parse() does not modify the given buffer, that's it. I would agree with you if I were actually changing the given buffer here via a const pointer, or were passing it to some other function which does so. What I am doing here and below is storing an address.