Attention is currently required from: laforge.
fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38023?usp=email )
Change subject: Introduce a new 'hexstr' type to represent hex-strings ......................................................................
Patch Set 2: Code-Review+1
(2 comments)
File src/osmocom/utils.py:
https://gerrit.osmocom.org/c/python/pyosmocom/+/38023/comment/1d628067_75d6d... : PS2, Line 141: hexstr Class names should use CamelCase in python (according to PEP 8):
https://peps.python.org/pep-0008/#class-names
Built-in Python's classes not always comply to this, but I believe user defined ones should?
https://gerrit.osmocom.org/c/python/pyosmocom/+/38023/comment/cb642983_64e97... : PS2, Line 151: other `... other: str) -> bool`?