Change in osmo-ttcn3-hacks[master]: Support for SBc-AP protocol as used on the MME-CBC interface - gerrit-log

18 Jul 2022


      Attention is currently required from: pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28603 )
Change subject: Support for SBc-AP protocol as used on the MME-CBC interface
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
File cbc/CBC_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28603/comment/661015f9_3cedc... 
PS5, Line 322: 	//	tx_list := msg.cell_list;
not sure we should keep those copy+pate bits from CBSP here? if yes, then it probably makes sense to have some comment about what is still missing.
Also, inconsistent comment styles: Here // and a few lines below /**/
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28603
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia6743e0a3e7974a5f2dd3ecf74ec331f646f6bc2
Gerrit-Change-Number: 28603
Gerrit-PatchSet: 5
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-CC: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Mon, 18 Jul 2022 08:01:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment