[L] Change in osmo-msc[master]: ASCI: Add VTY to configure GCR (Group Call Register) - gerrit-log

6 Jul 2023

Attention is currently required from: laforge.

jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33512
)

Change subject: ASCI: Add VTY to configure GCR (Group Call Register)
......................................................................

Patch Set 13:

(2 comments)

File src/libmsc/asci_vty.c:

https://gerrit.osmocom.org/c/osmo-msc/+/33512/comment/407a4d0f_329bcd53 
PS10, Line 219:       "mute-talker", "Mute talker's downlink")
...
  if it's only for testing then it probably should
be HIDDEN and maybe also not saved in the config fi […] It should not be only for me
testing the code, but also the users to test their handsets. Not writing this to the
config would require the user to user to unmute after every start of the MSC.

https://gerrit.osmocom.org/c/osmo-msc/+/33512/comment/0fa42445_91a419b5 
PS10, Line 261:       "no cell POINT_CODE [<0-65535>]", NO_STR
"Remove BSS/cell from current group\n" PC_ID_STR)
...
  as all our libosmo-sigtran code has user-configurable
point code format,  I think the same point cod […] Done

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33512
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I5bd034a62fc8b483f550d29103c2f7587198f590
Gerrit-Change-Number: 33512
Gerrit-PatchSet: 13
Gerrit-Owner: jolly &lt;andreas(a)eversberg.eu&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Attention: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Comment-Date: Thu, 06 Jul 2023 11:26:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: jolly &lt;andreas(a)eversberg.eu&gt;
Comment-In-Reply-To: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-MessageType: comment