Attention is currently required from: laforge. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31967 ) Change subject: contrib: Add BER testing tool ...................................................................... Patch Set 6: (3 comments) File contrib/ber/rtp_ber.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5284): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/0c83f43d_281d79ab PS6, Line 97: static const char *amr_rate_by_ft[] = { static const char * array should probably be static const char * const Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5284): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/d81decbe_9fd0ebc3 PS6, Line 416: if (rtp_seq_num_diff(seq_number, as->rx_last_seq) > 1) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5284): https://gerrit.osmocom.org/c/osmo-bts/+/31967/comment/843578fd_551e6fbd PS6, Line 480: while (1) { braces {} are not necessary for single statement blocks -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31967 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1cffa0ae959e29ec61775b13185fd1057ed7485a Gerrit-Change-Number: 31967 Gerrit-PatchSet: 6 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: tnt <tnt(a)246tNt.com> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 20 Mar 2023 20:01:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment