Attention is currently required from: pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28798 )
Change subject: Rename functions generating CBSP/SBc-AP Write-Replace request ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File include/osmocom/cbc/cbsp_msg.h:
https://gerrit.osmocom.org/c/osmo-cbc/+/28798/comment/459ad188_0fe38bb5 PS2, Line 5: struct osmo_cbsp_decoded *cbsp_gen_write_replace_req(void *ctx, const struct cbc_message *cbcmsg); cbsp_gen_write_replace_req seems to be a bit long. I am not familliar with SBc-AP". However If the "write" in the function name refers to the message it generates you could spare it. => "cbsp_gen_replace_req"? Probably I am wrong.