Attention is currently required from: pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32266 )
Change subject: bts: Proper tear down
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
File bts/BTS_Tests_OML.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32266/comment/9e46df5b_15ea…
PS1, Line 155: f_shutdown_helper
We already have `f_shutdown()` in
`library/Misc_Helpers. […]
My suggestion was to use `Misc_Helpers. f_shutdown()`
directly.
I see no real need for this local wrapper...
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32266
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I761ae94aa698a74bb30b8a6b1860358545f222b5
Gerrit-Change-Number: 32266
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 11 Apr 2023 13:57:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment