Jenkins Builder has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-abis/+/36277?usp=email )
Change subject: input/ipaccess: Make sure to say "TCP keepalive"
......................................................................
Patch Set 1:
(4 comments)
File src/input/ipaccess.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15104):
https://gerrit.osmocom.org/c/libosmo-abis/+/36277/comment/9c068a5a_74423f2f
PS1, Line 650: if (ret < 0) {
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15104):
https://gerrit.osmocom.org/c/libosmo-abis/+/36277/comment/cbd9e4b6_ccbcb37f
PS1, Line 650: if (ret < 0) {
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15104):
https://gerrit.osmocom.org/c/libosmo-abis/+/36277/comment/18633243_14cdac52
PS1, Line 652: "Failed to set TCP user timoeut:
%s\n",
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15104):
https://gerrit.osmocom.org/c/libosmo-abis/+/36277/comment/8ce2f52b_c29a6a15
PS1, Line 652: "Failed to set TCP user timoeut:
%s\n",
please, no spaces at the start of a line
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-abis/+/36277?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: rel-1.4.2
Gerrit-Change-Id: I01cbda27eb7826eb11f44e034d746b7c39b399a4
Gerrit-Change-Number: 36277
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Thu, 14 Mar 2024 17:14:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment