laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34029?usp=email )

Change subject: ASCI: Fix uninitialized values in vgcs_fsm.c, found by gcc 13.1.1.20230714 ......................................................................

Patch Set 3:

(2 comments)

File src/osmo-bsc/vgcs_fsm.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/34029/comment/cc6ee01b_c721e1bc PS1, Line 1083: struct gsm_lchan *lchan;

this also doesn't look like a fix for a warning, but an actual random-memory-dererference bug.

Done

https://gerrit.osmocom.org/c/osmo-bsc/+/34029/comment/1228a5da_66f61062 PS1, Line 542: if (!conn->vgcs_call.fi) { : cause = GSM0808_CAUSE_INCORRECT_VALUE; : goto reject; : }

this doesn't look like a fix for a compiler warning, but an actual bugfix where prior to this patch […]

Done