Attention is currently required from: laforge.

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32180 )

Change subject: cosmetic: Clarify language ip.access nanoBTS vs. all IPA Abis/IP ......................................................................

Patch Set 2: -Code-Review

(2 comments)

File src/osmo-bsc/bsc_vty.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/32180/comment/236193e3_f776a414 PS2, Line 1318: if (!is_ipa_abisip_bts(bts) || is_osmobts(bts)) { I don't see `NM_MT_IPACC_RESTART` being handled in osmo-bts.git, so looks like it's a nanoBTS specific command. The condition is indeed weird, I think it should be just `bts->type == GSM_BTS_TYPE_NANOBTS`.

File src/osmo-bsc/bts_vty.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/32180/comment/529ab12f_6a328eb2 PS2, Line 1923: ipaccess nanoBTS I think the logging message is still correct, it's a workaround for some nanoBTS fw versions. Not sure why would you want to use this command for other Abis/IP models like osmo-bts.