Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/31066 )

Change subject: ts_51_011: Implement Extended BCD Coding ......................................................................

Patch Set 2:

(1 comment)

File pySim/ts_51_011.py:

https://gerrit.osmocom.org/c/pysim/+/31066/comment/b85f994c_6beede23 PS2, Line 366: 'dialing_nr'/ExtendedBcdAdapter(BcdAdapter(Rpad(Bytes(10)))),

Just to be sure: Shouldn't this be: […]

yes, the ExtendedBcdAdapter is written in a way that it just translates the */# characters, and in order to get from bytes to re-ordered bcd nibbles you still need the BcdAdapter inside.