Jenkins Builder has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/34614?usp=email )
Change subject: ASCI: Add decoding of SYSTEM INFORMATION TYPE 10 $(ASCI)$
......................................................................
Patch Set 1:
(3 comments)
File src/host/layer23/src/common/sysinfo.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11588):
https://gerrit.osmocom.org/c/osmocom-bb/+/34614/comment/87cc0bee_a87fe7d5
PS1, Line 673: /* Increment frequency number for every <info field> and every
<next frequency> occurence. */
'occurence' may be misspelled - perhaps 'occurrence'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11588):
https://gerrit.osmocom.org/c/osmocom-bb/+/34614/comment/535256a8_d63ae535
PS1, Line 744: c->rxlev_acc_min_db = - 110;
space prohibited after that '-' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11588):
https://gerrit.osmocom.org/c/osmocom-bb/+/34614/comment/b0aa8708_21e5c542
PS1, Line 1092: if (rc == EOF) {
suspect code indent for conditional statements (8, 8)
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/34614?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I81c7929f6d951d8eef7d08624f0b72830370c448
Gerrit-Change-Number: 34614
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Tue, 03 Oct 2023 07:59:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment