Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27774 ) Change subject: osmo-bts-trx: amr_loop: improve logging in trx_loop_amr_input() ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/osmo-bts-trx/amr_loop.c: https://gerrit.osmocom.org/c/osmo-bts/+/27774/comment/46b39d5d_e0bfc3c4 PS1, Line 75: /* The threshold/hysteresis is in 0.5 dB steps, convert to cB: Here mi substitutes chan_stat->ul_ft, not chan_state->dl_cmr. But it's fine because mi == chan_state->dl_cmr due to early return in line 48. Same in all placed below. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27774 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I4feb3a3823799a290a50a48275e45f3331874d1a Gerrit-Change-Number: 27774 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 14 Apr 2022 12:42:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment