Attention is currently required from: osmith, pespin.
daniel has posted comments on this change by osmith. (
https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022?usp=email )
Change subject: Regenerate code with newer asn1c
......................................................................
Patch Set 3:
(2 comments)
File include/AARE-apdu.h:
https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022/comment/3932d954_cb6…
:
PS3, Line 1: /*
These header files are all in the wrong directory. […]
This library instead sets
```osmo_asn1_tcapdir = $(includedir)/osmocom/tcap```
But I can see that our other libraries keep the directory structure in the source.
I'll change it
File src/constr_CHOICE_print.c:
https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022/comment/3972b78a_430…
:
PS3, Line 1: /*
I would really like/suggest to keep the generated C
files in a separate directory, like done in osmo […]
So far there is only the
generated files.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41022?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-asn1-tcap
Gerrit-Branch: master
Gerrit-Change-Id: If43a5d518f94fa558a3dff563a1c7aa31c925fec
Gerrit-Change-Number: 41022
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 04 Sep 2025 10:05:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>