Attention is currently required from: neels, fixeria.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-pfcp/+/31741 )
Change subject: build: fix linking gen__pfcp_ies_auto to use build-tree libosmo-gtlv
......................................................................
Patch Set 1:
(1 comment)
File src/libosmo-pfcp/Makefile.am:
https://gerrit.osmocom.org/c/libosmo-pfcp/+/31741/comment/fd121bc5_21d15e0a
PS1, Line 68: gen__pfcp_ies_auto_LDFLAGS
This looks weird, both before and after your patch.
Local `*. […]
Regarding order: lower level libs (eg libosmcoore) should be *after*
the libs depending on it.
So in here the current order is correct.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-pfcp/+/31741
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: I2e92238b214d8e79bab1095d6093139bad05bc66
Gerrit-Change-Number: 31741
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 08 Mar 2023 09:38:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment