[L] Change in libosmo-abis[master]: ipaccess: Convert BSC OML & RSL link to use stream_srv
Attention is currently required from: daniel, fixeria, laforge, osmith.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38983?usp=email )
Change subject: ipaccess: Convert BSC OML & RSL link to use stream_srv ......................................................................
Patch Set 4:
(4 comments)
File TODO-RELEASE:
https://gerrit.osmocom.org/c/libosmo-abis/+/38983/comment/9725326f_38698b38?... : PS4, Line 14: ABI
You're removing a symbol, so it's actually API breakage, not ABI.
Done
File src/input/ipaccess.c:
https://gerrit.osmocom.org/c/libosmo-abis/+/38983/comment/bc7775b8_66a7bad7?... : PS4, Line 387: ballback
callback
Done
https://gerrit.osmocom.org/c/libosmo-abis/+/38983/comment/9f166264_8add7b63?... : PS4, Line 470: default:
maybe put a log msg here?
Done
https://gerrit.osmocom.org/c/libosmo-abis/+/38983/comment/d351a780_9695c073?... : PS4, Line 705: /* PESPIN: TODO: use osmo_stream_srv_send() instead */
did you leave this TODO intentionally?
Done
-
pespin