Jenkins Builder has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/31025 )
Change subject: Introduce tundev API
......................................................................
Patch Set 1:
(2 comments)
File src/core/tun.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2873):
https://gerrit.osmocom.org/c/libosmocore/+/31025/comment/8cd399c4_22791326
PS1, Line 111: else
else is not generally useful after a break or return
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2873):
https://gerrit.osmocom.org/c/libosmocore/+/31025/comment/aff75e9e_88eafea0
PS1, Line 132: if (rc < 0) {
braces {} are not necessary for any arm of this statement
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/31025
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I3463271666df1e85746fb7b06ec45a17024b8c53
Gerrit-Change-Number: 31025
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Thu, 19 Jan 2023 20:03:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment