Attention is currently required from: Hoernchen, dexter, jolly, lynxis lazus.
laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42192?usp=email )
Change subject: ccid_device: Reject XfrBlock with zero-length data
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I don't have a strong opinion. […]
@jolly just tested with a Omnikey 6121, which apparently actually transmits it to the card and gets a R-APDU 6881 from the card. So it doesn't reject it at the CCID layer but lets the card respond, in this case with the somewhat odd "Logical channel not supported" status word.
I still think it's fine to reject it at the CCID level. In any case, rejecting it is better than running into a crash or assert.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42192?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: I65df88477e4b1c03dc20a8d41e5cbd1c9f363ba8
Gerrit-Change-Number: 42192
Gerrit-PatchSet: 1
Gerrit-Owner: laforge
laforge@osmocom.org
Gerrit-Reviewer: Hoernchen
ewild@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly
andreas@eversberg.eu
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: lynxis lazus
lynxis@fe80.eu
Gerrit-CC: dexter
pmaier@sysmocom.de
Gerrit-Attention: Hoernchen
ewild@sysmocom.de
Gerrit-Attention: jolly
andreas@eversberg.eu
Gerrit-Attention: lynxis lazus
lynxis@fe80.eu
Gerrit-Attention: dexter
pmaier@sysmocom.de
Gerrit-Comment-Date: Fri, 27 Feb 2026 09:33:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge
laforge@osmocom.org
Comment-In-Reply-To: lynxis lazus
lynxis@fe80.eu