Attention is currently required from: fixeria, laforge.

jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30763?usp=email )

Change subject: core: Add software UART implementation ......................................................................

Patch Set 3:

(2 comments)

File include/osmocom/core/soft_uart.h:

https://gerrit.osmocom.org/c/libosmocore/+/30763/comment/133ce3d3_0134743a PS3, Line 28: uart_parity_mode For completeness you should add OSMO_SUART_PARITY_MARK and OSMO_SUART_PARITY_SPACE. (parity bit always 1 or always 0 respectively)

File src/core/soft_uart.c:

https://gerrit.osmocom.org/c/libosmocore/+/30763/comment/bbc7357e_c1760049 PS3, Line 127: suart->rx.shift_reg |= 0x80 The last RX bit is always MSB of shift_reg. If num_data_bits is less than 8, the result is misaligned when forwarding to receive buffer.