Attention is currently required from: fixeria, laforge.

View Change

2 comments:

• File include/osmocom/core/soft_uart.h:

  • Patch Set #3, Line 28: uart_parity_mode

    For completeness you should add OSMO_SUART_PARITY_MARK and OSMO_SUART_PARITY_SPACE. (parity bit always 1 or always 0 respectively)

• File src/core/soft_uart.c:

  • Patch Set #3, Line 127: suart->rx.shift_reg |= 0x80

    The last RX bit is always MSB of shift_reg. If num_data_bits is less than 8, the result is misaligned when forwarding to receive buffer.

To view, visit change 30763. To unsubscribe, or for help writing mail filters, visit settings.