[M] Change in libosmocore[master]: gpsr_ns2_udp: Use osmo_io_fd instead of osmo_fd - gerrit-log

1 Apr 2023


      Attention is currently required from: laforge, lynxis lazus.
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30936 )
Change subject: gpsr_ns2_udp: Use osmo_io_fd instead of osmo_fd
......................................................................
Patch Set 7:
(1 comment)
File src/gb/gprs_ns2_udp.c:
https://gerrit.osmocom.org/c/libosmocore/+/30936/comment/f00d7f2a_4d452108 
PS6, Line 72: if (priv->iofd)
            : 		osmo_iofd_free(priv->iofd);
...
if a function is called free() it should handle calls with NULL.  If it doesn't, please fix it. […]
ACK, in the new patchset osmo_iofd_free() can handle a call with NULL.
-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30936
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Id776d2d9f35c304620f3d5b94492148dd987f5a0
Gerrit-Change-Number: 30936
Gerrit-PatchSet: 7
Gerrit-Owner: daniel dwillmann@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus lynxis@fe80.eu
Gerrit-CC: laforge laforge@osmocom.org
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Attention: lynxis lazus lynxis@fe80.eu
Gerrit-Comment-Date: Sat, 01 Apr 2023 12:27:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge laforge@osmocom.org
Gerrit-MessageType: comment