neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31771 ) Change subject: error log: osmo_sock_init2_multiaddr() v4/v6 mix ...................................................................... Patch Set 2: (1 comment) File src/core/socket.c: https://gerrit.osmocom.org/c/libosmocore/+/31771/comment/9f9a65ab_030d0e02 PS1, Line 776: ((flags & OSMO_SOCK_F_BIND) && (flags & OSMO_SOCK_F_CONNECT)) && : !addrinfo_has_in6addr_any((const struct addrinfo **)res_loc, local_hosts_cnt) && : (loc_has_v4addr != rem_has_v4addr || loc_has_v6addr != rem_has_v6addr)) { i guess we need a new issue for this if it shouldn't be forgotten in this comment... -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31771 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0fd12b08e0788ce3af6dc519ff8c82ad196a115f Gerrit-Change-Number: 31771 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Mar 2023 20:15:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment