Attention is currently required from: pespin.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36522?usp=email )
Change subject: hnbgw: Make RAB release cause configurable
......................................................................
Patch Set 1:
(1 comment)
File hnbgw/HNBGW_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36522/comment/5c53a832_e80c…
PS1, Line 1057: integer cn_nr := 0, template (value) RANAP_IEs.Cause rab_rel_cause
:= ts_RanapCause_om_intervention) := {
This would be far easier to read if it was in its own
line...
Our coding style permits line lengths of 120 characters, and other arguments
of this function prior to my change were not each on a separate line. Please let's
not introduce subjective statements of what is easier to read for you into code review,
unless that code clearly violates existing coding style or practices.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36522?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie072dafbc3378739d41411632e33a8a1ec1ed572
Gerrit-Change-Number: 36522
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 05 Apr 2024 11:27:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment