Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27805 )

Change subject: osmo-bts-trx: fix scheduling of dummy FACCH/H and FACCH/F ......................................................................

Patch Set 1:

(1 comment)

File src/osmo-bts-trx/sched_lchan_tchf.c:

https://gerrit.osmocom.org/c/osmo-bts/+/27805/comment/02cd1fec_3babd0b7 PS1, Line 333: chan_state->dl_facch_bursts = 8;

you're not setting dl_ongoing_facch here (unlike TCH/H). […]

Yes, this is intentional: dl_ongoing_facch is only used in tx_tchh_fn(), where you need to skip encoding of the buffer while sending the middle two bursts of FACCH/H. Here both speech and FACCH/F have equal interleaving period.