Attention is currently required from: laforge.
pespin has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/osmo-hnbgw/+/39983?usp=email )
Change subject: Rename function s/hnbgw_decode_ranap_co/hnbgw_decode_ranap_cn_co/g
......................................................................
Patch Set 1:
(2 comments)
File src/osmo-hnbgw/context_map_rua.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/39983/comment/df1321d5_af5483a7?u… :
PS1, Line 140: hnbgw_decode_ranap_cn_co
now I'm confused. _cn_ seems to indicate from the
core network. […]
That's how all code in osmo-iuh is named.
My understanding is that "cn" means "we decode from CN point of view".
That means decoding UL traffic and transmitting DL traffic.
In the HNBGW case, that means when traffic comes from RUA we are the "CN" and
hence we decode UL traffic and transmit DL traffic.
https://gerrit.osmocom.org/c/osmo-hnbgw/+/39983/comment/939d6a7a_4ff40868?u… :
PS1, Line 148: rc = ranap_cn_rx_co_decode2(message, msgb_l2(ranap_msg),
msgb_l2len(ranap_msg));
See how it matches this osmo-iuh naming. "cn".
--
To view, visit
https://gerrit.osmocom.org/c/osmo-hnbgw/+/39983?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: Ia4e5a21a9724ebf759b62c13759a776189b09e91
Gerrit-Change-Number: 39983
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 08 Apr 2025 18:15:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>