Attention is currently required from: Jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/30448 )
Change subject: Remove mISDN header from received channel data ......................................................................
Patch Set 1:
(2 comments)
File src/input/misdn.c:
https://gerrit.osmocom.org/c/libosmo-abis/+/30448/comment/6e546296_f4885856 PS1, Line 376: ms you can do msg->l2h = msgb_pull(msg, MISDN_HEADER_LEN). Or you could even keep "msg->l2h = msg->data + MISDN_HEADER_LEN;" and then call msgb_pull_to_l2(msg). I think the last options is most clear, but it's not critical.
https://gerrit.osmocom.org/c/libosmo-abis/+/30448/comment/cc9a8c7a_2475f6c6 PS1, Line 459: msgb_pull(msg, MISDN_HEADER_LEN); same here