Attention is currently required from: laforge.
Jenkins Builder has posted comments on this change by Hoernchen. (
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39759?usp=email )
Change subject: Make ch9 usb tests work
......................................................................
Patch Set 2:
(4 comments)
File sysmoOCTSIM/main.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-22023):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39759/comment/bc0054ef_32…
:
PS2, Line 593: continue;
please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-22023):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39759/comment/44457597_3f…
:
PS2, Line 610: // ;
please, no space before tabs
File sysmoOCTSIM/usb/class/ccid/device/ccid_df.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-22023):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39759/comment/91793d14_03…
:
PS2, Line 228: // return ERR_NOT_FOUND;
please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-22023):
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39759/comment/6fb174d6_56…
:
PS2, Line 242: // return ERR_NONE;
please, no space before tabs
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39759?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: Icadaee9d8cbe24bd3cac002cc4f710dcf846a32b
Gerrit-Change-Number: 39759
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 11 Mar 2025 17:47:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No