pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/26885 )
Change subject: Do not turn some compiler warnings into errors by default ......................................................................
Do not turn some compiler warnings into errors by default
We build with --enable-werror during development and in CI. If the code is built with a different compiler that throws additional warnings, it should not stop the build.
This patch also effectively removes dependency on autoconf-archive.
Related: OS#5289 Related: SYS#5789 Change-Id: I7512a4230a5bbba6c67172c2572c98b9ab20c923 --- M configure.ac M contrib/osmo-hnbgw.spec.in M debian/control 3 files changed, 0 insertions(+), 14 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/85/26885/1
diff --git a/configure.ac b/configure.ac index 3e02bd9..a88ff42 100644 --- a/configure.ac +++ b/configure.ac @@ -36,11 +36,6 @@ fi PKG_PROG_PKG_CONFIG([0.20])
-dnl check for AX_CHECK_COMPILE_FLAG -m4_ifdef([AX_CHECK_COMPILE_FLAG], [], [ - AC_MSG_ERROR([Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect.]) - ]) - dnl checks for libraries AC_SEARCH_LIBS([dlopen], [dl dld], [LIBRARY_DL="$LIBS";LIBS=""]) AC_SUBST(LIBRARY_DL) @@ -113,13 +108,6 @@ CFLAGS="$saved_CFLAGS" AC_SUBST(SYMBOL_VISIBILITY)
-AX_CHECK_COMPILE_FLAG([-Werror=implicit], [CFLAGS="$CFLAGS -Werror=implicit"]) -AX_CHECK_COMPILE_FLAG([-Werror=maybe-uninitialized], [CFLAGS="$CFLAGS -Werror=maybe-uninitialized"]) -AX_CHECK_COMPILE_FLAG([-Werror=memset-transposed-args], [CFLAGS="$CFLAGS -Werror=memset-transposed-args"]) -AX_CHECK_COMPILE_FLAG([-Wnull-dereference], [CFLAGS="$CFLAGS -Wnull-dereference"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-array-argument], [CFLAGS="$CFLAGS -Werror=sizeof-array-argument"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-pointer-memaccess], [CFLAGS="$CFLAGS -Werror=sizeof-pointer-memaccess"]) - # Coverage build taken from WebKit's configure.in AC_MSG_CHECKING([whether to enable code coverage support]) AC_ARG_ENABLE(coverage, diff --git a/contrib/osmo-hnbgw.spec.in b/contrib/osmo-hnbgw.spec.in index 5ab0f5a..1d30e56 100644 --- a/contrib/osmo-hnbgw.spec.in +++ b/contrib/osmo-hnbgw.spec.in @@ -24,7 +24,6 @@ Group: Hardware/Mobile URL: https://osmocom.org/projects/osmohnbgw Source: %{name}-%{version}.tar.xz -BuildRequires: autoconf-archive BuildRequires: automake >= 1.9 BuildRequires: libtool >= 2 BuildRequires: lksctp-tools-devel diff --git a/debian/control b/debian/control index 1ea3ad2..d9ab85f 100644 --- a/debian/control +++ b/debian/control @@ -6,7 +6,6 @@ dh-autoreconf, autotools-dev, autoconf, - autoconf-archive, automake, libtool, pkg-config,
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/26885 )
Change subject: Do not turn some compiler warnings into errors by default ......................................................................
Patch Set 1: Code-Review+2
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/26885 )
Change subject: Do not turn some compiler warnings into errors by default ......................................................................
Do not turn some compiler warnings into errors by default
We build with --enable-werror during development and in CI. If the code is built with a different compiler that throws additional warnings, it should not stop the build.
This patch also effectively removes dependency on autoconf-archive.
Related: OS#5289 Related: SYS#5789 Change-Id: I7512a4230a5bbba6c67172c2572c98b9ab20c923 --- M configure.ac M contrib/osmo-hnbgw.spec.in M debian/control 3 files changed, 0 insertions(+), 14 deletions(-)
Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved
diff --git a/configure.ac b/configure.ac index 3e02bd9..a88ff42 100644 --- a/configure.ac +++ b/configure.ac @@ -36,11 +36,6 @@ fi PKG_PROG_PKG_CONFIG([0.20])
-dnl check for AX_CHECK_COMPILE_FLAG -m4_ifdef([AX_CHECK_COMPILE_FLAG], [], [ - AC_MSG_ERROR([Please install autoconf-archive; re-run 'autoreconf -fi' for it to take effect.]) - ]) - dnl checks for libraries AC_SEARCH_LIBS([dlopen], [dl dld], [LIBRARY_DL="$LIBS";LIBS=""]) AC_SUBST(LIBRARY_DL) @@ -113,13 +108,6 @@ CFLAGS="$saved_CFLAGS" AC_SUBST(SYMBOL_VISIBILITY)
-AX_CHECK_COMPILE_FLAG([-Werror=implicit], [CFLAGS="$CFLAGS -Werror=implicit"]) -AX_CHECK_COMPILE_FLAG([-Werror=maybe-uninitialized], [CFLAGS="$CFLAGS -Werror=maybe-uninitialized"]) -AX_CHECK_COMPILE_FLAG([-Werror=memset-transposed-args], [CFLAGS="$CFLAGS -Werror=memset-transposed-args"]) -AX_CHECK_COMPILE_FLAG([-Wnull-dereference], [CFLAGS="$CFLAGS -Wnull-dereference"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-array-argument], [CFLAGS="$CFLAGS -Werror=sizeof-array-argument"]) -AX_CHECK_COMPILE_FLAG([-Werror=sizeof-pointer-memaccess], [CFLAGS="$CFLAGS -Werror=sizeof-pointer-memaccess"]) - # Coverage build taken from WebKit's configure.in AC_MSG_CHECKING([whether to enable code coverage support]) AC_ARG_ENABLE(coverage, diff --git a/contrib/osmo-hnbgw.spec.in b/contrib/osmo-hnbgw.spec.in index 5ab0f5a..1d30e56 100644 --- a/contrib/osmo-hnbgw.spec.in +++ b/contrib/osmo-hnbgw.spec.in @@ -24,7 +24,6 @@ Group: Hardware/Mobile URL: https://osmocom.org/projects/osmohnbgw Source: %{name}-%{version}.tar.xz -BuildRequires: autoconf-archive BuildRequires: automake >= 1.9 BuildRequires: libtool >= 2 BuildRequires: lksctp-tools-devel diff --git a/debian/control b/debian/control index 1ea3ad2..d9ab85f 100644 --- a/debian/control +++ b/debian/control @@ -6,7 +6,6 @@ dh-autoreconf, autotools-dev, autoconf, - autoconf-archive, automake, libtool, pkg-config,
-
laforge -
pespin