Attention is currently required from: jolly, pespin.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/32932 )
Change subject: ASCI: Add message definition and encoding according to 3GPP TS 48.008
......................................................................
Patch Set 6:
(1 comment)
File include/osmocom/gsm/gsm0808.h:
https://gerrit.osmocom.org/c/libosmocore/+/32932/comment/93271d6c_77592309
PS5, Line 386: struct sockaddr_storage *aoip_transport_layer;
osmocom/core/socket.h will not work on embedded
systems. see line 5. […]
the solution is to not build gsm0808 on embedded targets.
The embedded builds are for osmocom-bb or simtrace2, where you just want code like msgb,
linked lists, sercomm, ... - but certainly no 08.08 is required. So IMHO it would be fine
to #ifdef this all out
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/32932
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib94c64136c31ce4af67c314a8550d93946cc844f
Gerrit-Change-Number: 32932
Gerrit-PatchSet: 6
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 02 Jun 2023 08:28:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: jolly <andreas(a)eversberg.eu>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment