Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33495 ) Change subject: osmo_io: Use bitfield for various boolean flags ...................................................................... Patch Set 1: (2 comments) File src/core/osmo_io_internal.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-8649): https://gerrit.osmocom.org/c/libosmocore/+/33495/comment/ecda9da0_c56a05d5 PS1, Line 37: #define IOFD_FLAG_SET(iofd, flag) \ Single statement macros should not use a do {} while (0) loop Robot Comment from checkpatch (run ID jenkins-gerrit-lint-8649): https://gerrit.osmocom.org/c/libosmocore/+/33495/comment/beb0829f_4acf0289 PS1, Line 42: #define IOFD_FLAG_UNSET(iofd, flag) \ Single statement macros should not use a do {} while (0) loop -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33495 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic134e4c8d791c34778202fea98a70bc04007a113 Gerrit-Change-Number: 33495 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 27 Jun 2023 08:12:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment