Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29334 ) Change subject: Don't permit anything but HNB (de)registration until HNB is registered ...................................................................... Patch Set 3: (1 comment) File src/osmo-hnbgw/hnbgw_hnbap.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/29334/comment/2d5b462e_1b5bb7ba PS3, Line 550: } I'd prefer exit-early here instead of else {... This should also make the patch easier to read, avoiding indenting the entire block -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29334 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Iaa62ce89f4ffbff868309bfb8b1df7ebcca5c44a Gerrit-Change-Number: 29334 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Sep 2022 21:10:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment