Attention is currently required from: neels, pespin, dexter.
msuraev has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/28995 )
Change subject: Add osmo_sockaddr_str helpers to print without port
......................................................................
Patch Set 9:
(2 comments)
Patchset:
PS8:
AF_UNSPEC is not valid and should return an error rc.
[…]
Done
File src/sockaddr_str.c:
https://gerrit.osmocom.org/c/libosmocore/+/28995/comment/bf50752a_c928cbac
PS7, Line 389: guess = (src->ss_family == AF_UNSPEC) ?
osmo_sockaddr_guess_unspec((const struct sockaddr *)src) : src->ss_family;
No dots or colons are passed to that function inside
struct sockaddr, so you cannot really know that […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/28995
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I36f20701663c3c7eae7fedc6551da44800b325bf
Gerrit-Change-Number: 28995
Gerrit-PatchSet: 9
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 29 Sep 2022 05:38:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de>
Gerrit-MessageType: comment