[M] Change in osmo-bts[master]: pcu_sock: do not receive a TXT ind. with PCU_VERSION for a specific BTS - gerrit-log

28 Nov 2024

Attention is currently required from: pespin.

dexter has posted comments on this change by dexter. (
https://gerrit.osmocom.org/c/osmo-bts/+/38958?usp=email )

Change subject: pcu_sock: do not receive a TXT ind. with PCU_VERSION for a specific BTS
......................................................................

Patch Set 2:

(1 comment)

File src/common/pcu_sock.c:

https://gerrit.osmocom.org/c/osmo-bts/+/38958/comment/a84ca2b1_d15c468e?usp… :
PS1, Line 947: #define ENSURE_BTS_OBJECT() \
...
  better pass "bts" as a param here, so it
doesn't get magically assigned below. shouldn't we better have something
like this?:

#define ENSURE_BTS_OBJECT(bts_nr) ({ \
_bts = magic(); \
_bts; \
})

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38958?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I1bb8d0ec5e8d4b9f822f94249a75d8dc477144a3
Gerrit-Change-Number: 38958
Gerrit-PatchSet: 2
Gerrit-Owner: dexter &lt;pmaier(a)sysmocom.de&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Comment-Date: Thu, 28 Nov 2024 09:57:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin &lt;pespin(a)sysmocom.de&gt;