Attention is currently required from: laforge, pespin.

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/39830?usp=email )

Change subject: fixup: rsl: properly initialize MS/BS Power Control state ......................................................................

Patch Set 1:

(2 comments)

File src/common/rsl.c:

https://gerrit.osmocom.org/c/osmo-bts/+/39830/comment/02cbe73a_6fcfca61?usp=... : PS1, Line 1992: memset(&lchan->bs_power_ctrl, 0, sizeof(lchan->bs_power_ctrl));

ok, more initialization here rather than re-set-to-sane-defaults during deactivation. […]

Currently we're not really resetting anything during lchan deactivation (we only free() some msgbs, see `lchan_set_state()`). If we fail to initialize a field here, it will hold the value that was assigned during previous activation. This is not nice and I believe we should rework the code to clean things up on deactivation. But for now I just wanted to fix a specific problem.

https://gerrit.osmocom.org/c/osmo-bts/+/39830/comment/a4334b92_41cac0f6?usp=... : PS1, Line 2059: lchan->ms_power_ctrl.current = lchan->ms_power_ctrl.max;

so this means always the current level becomes max level. […]

I suggest you to check the old code (left side of diff). This is exactly what we were doing, except that `lchan->ms_power_ctrl.current` was incorrectly initialized with the old value.