Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/39830?usp=email ) Change subject: fixup: rsl: properly initialize MS/BS Power Control state ...................................................................... Patch Set 1: (2 comments) File src/common/rsl.c: https://gerrit.osmocom.org/c/osmo-bts/+/39830/comment/02cbe73a_6fcfca61?usp… : PS1, Line 1992: memset(&lchan->bs_power_ctrl, 0, sizeof(lchan->bs_power_ctrl)); Currently we're not really resetting anything during lchan deactivation (we only free() some msgbs, see `lchan_set_state()`). If we fail to initialize a field here, it will hold the value that was assigned during previous activation. This is not nice and I believe we should rework the code to clean things up on deactivation. But for now I just wanted to fix a specific problem. https://gerrit.osmocom.org/c/osmo-bts/+/39830/comment/a4334b92_41cac0f6?usp… : PS1, Line 2059: lchan->ms_power_ctrl.current = lchan->ms_power_ctrl.max; I suggest you to check the old code (left side of diff). This is exactly what we were doing, except that `lchan->ms_power_ctrl.current` was incorrectly initialized with the old value. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/39830?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I46c881d5a3959c2542610ed767e0f131d01f9f98 Gerrit-Change-Number: 39830 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Mar 2025 17:08:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>