Attention is currently required from: laforge, pespin.

View Change

2 comments:

• File src/common/rsl.c:

  • Patch Set #1, Line 1992: memset(&lchan->bs_power_ctrl, 0, sizeof(lchan->bs_power_ctrl));

    ok, more initialization here rather than re-set-to-sane-defaults during deactivation. […]

    Currently we're not really resetting anything during lchan deactivation (we only free() some msgbs, see `lchan_set_state()`). If we fail to initialize a field here, it will hold the value that was assigned during previous activation. This is not nice and I believe we should rework the code to clean things up on deactivation. But for now I just wanted to fix a specific problem.

  • Patch Set #1, Line 2059: lchan->ms_power_ctrl.current = lchan->ms_power_ctrl.max;

    so this means always the current level becomes max level. […]

    I suggest you to check the old code (left side of diff). This is exactly what we were doing, except that `lchan->ms_power_ctrl.current` was incorrectly initialized with the old value.

To view, visit change 39830. To unsubscribe, or for help writing mail filters, visit settings.