[M] Change in osmocom-bb[master]: [untested] layer23: migrate away from gsm48_generate_mid_from_* - gerrit-log

14 Jun 2023


      Attention is currently required from: laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/33318 )
Change subject: [untested] layer23: migrate away from gsm48_generate_mid_from_*
......................................................................
Patch Set 1:
(1 comment)
File src/host/layer23/src/mobile/gsm48_mm.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/33318/comment/a0821863_78963b18 
PS1, Line 310: 			int rc = osmo_mobile_identity_encode_buf(buf, 11, &mi, false);
I think this one is missing the encoding of the GSM48_IE_MOBILE_ID part. See libosmo-gprs.git/src/gmm/gmm_pdu.c:238
-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/33318
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ib0d7f76cd635e8d1092ffc1d07ecb29ec0435dda
Gerrit-Change-Number: 33318
Gerrit-PatchSet: 1
Gerrit-Owner: laforge laforge@osmocom.org
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Comment-Date: Wed, 14 Jun 2023 14:40:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment