fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32172 )
Change subject: gprs: disallow setting NSVC remote port to 0 ......................................................................
gprs: disallow setting NSVC remote port to 0
0 is not a valid remote port and shall not be permitted.
Change-Id: I46d5ad247ff2da7b319da0793e1d57561183bc8e Related: OS#5979 --- M src/osmo-bsc/bts_vty.c M tests/gprs_params.vty 2 files changed, 17 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/72/32172/1
diff --git a/src/osmo-bsc/bts_vty.c b/src/osmo-bsc/bts_vty.c index e02c2d5..21c7b43 100644 --- a/src/osmo-bsc/bts_vty.c +++ b/src/osmo-bsc/bts_vty.c @@ -1486,7 +1486,7 @@ DEFUN_USRATTR(cfg_bts_gprs_nsvc_rport, cfg_bts_gprs_nsvc_rport_cmd, X(BSC_VTY_ATTR_RESTART_ABIS_OML_LINK), - "gprs nsvc <0-1> remote udp port <0-65535>", + "gprs nsvc <0-1> remote udp port <1-65535>", GPRS_TEXT NSVC_TEXT "GPRS NS Remote UDP Port\n" "GPRS NS Remote UDP Port\n" diff --git a/tests/gprs_params.vty b/tests/gprs_params.vty index 048420b..9b2622b 100644 --- a/tests/gprs_params.vty +++ b/tests/gprs_params.vty @@ -71,7 +71,7 @@ OsmoBSC(config-net-bts)# gprs nsvc 0 remote udp ? port GPRS NS Remote UDP Port OsmoBSC(config-net-bts)# gprs nsvc 0 remote udp port ? - <0-65535> GPRS NS Remote UDP Port Number + <1-65535> GPRS NS Remote UDP Port Number OsmoBSC(config-net-bts)# gprs nsvc 0 remote ip ? A.B.C.D GPRS NS Remote IPv4 Address X:X::X:X GPRS NS Remote IPv6 Address @@ -102,3 +102,6 @@ gprs nsvc 1 remote ip 1.2.3.4 gprs nsvc 1 remote udp port 23032 ... + +OsmoBSC(config-net-bts)# gprs nsvc 0 remote udp port 0 +% Unknown command.
-
fixeria