Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/32406 ) Change subject: ts_51_011: fix EF_ServiceTable: use self for static method ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: inheritance in a static method? I'm not an OOP expert but that doesn't make much sense imho, since the inheritance is applied on the object instance, which doesn't really exist in an static method.... I'm not hard blocking this change but I have the feeling it goes into the wrong direction. Opinions from others are welcome. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/32406 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3590dda341d534deb1b7f4743ea31ab16dbd6912 Gerrit-Change-Number: 32406 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 24 Apr 2023 09:05:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment