Attention is currently required from: pespin.

neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39310?usp=email )

Change subject: add osmo_stream_cli_set_name_f() ......................................................................

Patch Set 2:

(2 comments)

Patchset:

PS1:

I'm fine with merging this, I know several places where we are actually generating a string in a sta […]

ack -> separate patch

File src/stream_cli.c:

https://gerrit.osmocom.org/c/libosmo-netif/+/39310/comment/a82d2f8e_b7bbf942... : PS1, Line 674: osmo_stream_cli_set_name_f(cli, "%s", name);

I'd rather duplicate a couple lines than going through the whole vararg parsing here....

two reasons to disagree:

a) the vararg parsing is not the slow part, the talloc is. There is no optimization effect.

b) IIUC this code happens when establishing links, so it is not performance relevant. So this clearly calls for avoiding code dup instead of optimizing.